feat(trace-tree-node): Mitigating error node type guards usage #104501
+923
−446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
…k/trace-tree-node-error-guards-usage
Abdkhan14
commented
Dec 9, 2025
| true | ||
| ); | ||
| const startTimestamp = 'start_timestamp' in event ? event.start_timestamp : undefined; | ||
| // TODO Abdullah Khan: Clean this up once getRepresentativeTraceEvent is moved to the TraceTree class |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/views/performance/newTraceDetails/traceHeader/meta.tsx
Outdated
Show resolved
Hide resolved
gggritso
approved these changes
Dec 9, 2025
…104503) - Replaced the `getRepresentativeTraceEvent` util to `TraceTree.findRepresentativeTraceNode`. - By doing so we can traverse the generic `baseNode.children` nodes and have access to all new functionality. Also: - Made use of the `baseNode.isEAPEvent` property - Added a `baseNode.traceItemDataset` property --------- Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Abdkhan14
merged commit 83bba26
into
abdk/trace-tree-node-uptime-check-guard-usage
38 of 39 checks passed
| ? rep.event[OurLogKnownFieldKey.ID] | ||
| : rep.event.event_id | ||
| : rep.event.id | ||
| : ''; |
Contributor
There was a problem hiding this comment.
Bug: Wrong property checked in eventId condition
The condition for extracting eventId checks for OurLogKnownFieldKey.PROJECT_ID in the event, but then accesses OurLogKnownFieldKey.ID. The original code checked OurLogKnownFieldKey.ID in rep.event before accessing the ID field. While this works in practice because logs always contain both fields, it's checking the wrong property and could fail if the data contract changes. The condition should check for the property that's actually being accessed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.